Also set CMake version range to prevent deprecation warnings.

Shouldn't max version be 3.30? I read from doc that 3.31 introduces the deprecation warnings for <3.10.

Shouldn't max version be 3.30? I read from doc that 3.31 introduces the deprecation warnings for <3.10.

I don't know much about CMake. I saw the warning so I just put the current version shipped with MSVC there and the warning is gone.

https://cmake.org/cmake/help/latest/command/cmake_minimum_required.html
"Changed in version 3.31: Compatibility with versions of CMake older than 3.10 is deprecated.

Please change 3.31 to 3.30

Fun fact: back to 3.5 in CMake 4.0, looks like that deprecating up to 3.10 was not a good idea, but impossible to say to accept v4.0+ in addition to 3.30-, so 3.30...

It appears that after changing 3.31 to 3.30, another warning has returned:

CMake Warning (dev) at CMakeLists.txt:456 (install):
  Policy CMP0177 is not set: install() DESTINATION paths are normalized.  Run
  "cmake --help-policy CMP0177" for policy details.  Use the cmake_policy
  command to set the policy and suppress this warning.
This warning is for project developers.  Use -Wno-dev to suppress it.

Fixed CMake on Windows was building debug version and too slow.

Now there is only one deprecation warning left from ZenLib that should be gone after MediaArea/ZenLib#185

Now there is only one deprecation warning left from ZenLib that should be gone after MediaArea/ZenLib#185

I am not keen on the max value but fair enough for the moment, until someone does fix the warnings.

Thanks.

not a big deal, but is it expected to have "Unix (windows-latest, cmake" check name, "Unix" for a Windows build using Windows host if I understand well.

not a big deal, but is it expected to have "Unix (windows-latest, cmake" check name, "Unix" for a Windows build using Windows host if I understand well.

Because since there is already existing CMake workflow, I just add the Windows one there and it uses Unix as job name. Maybe I should override the name for Windows.

Maybe I should override the name for Windows.

Would be nice to have.

(for macOS too, I guess :) )

What about like this? I renamed the jobs to Build and MSBuild. Also added a define to prevent unused zlib tests/examples from being built.

No more warnings remain. I think using 3.31 as max should be alright. zlib uses this version as max too.

What about like this? I renamed the jobs to Build and MSBuild.

Fair enough for the moment.

I think using 3.31 as max should be alright.

I like to have fixes instead of limiting the version but CMake is definitely need my priority, especially because we don't use it ourselves, so I let other people manage that.
(with the constraint that I want to keep compatibility with very old CMake version, so it does not help to "fix" the warnings :) )

I like to have fixes instead of limiting the version

If I understand correctly it is not limiting but stating that it has been tested up to 3.31 so there won't be deprecation warnings and so on.

If I understand correctly it is not limiting but stating that it has been tested up to 3.31 so there won't be deprecation warnings and so on.

Right. Just that I would like to have a CMake script without warning for all CMake versions, but I guess it is not possible, or at least not easily. And CMake 3.5 "format" is still supporte by CMake 4+ so fine enough. Just a nice to have and definitely not the priority :).
(I try to manage your other PRs, which are a lot more important than CMake, by the end of the month)

would like to have a CMake script without warning for all CMake versions

Are there still warnings for certain versions? I think there should be no more now?

Are there still warnings for certain versions? I think there should be no more now?

I mena, when removing the "max" version. Here it is a workaround, not a full compatibility.
But again, not a priority, I just do a remark that the "max" version is a workaround (and this is OK) and not a "final" fix.

especially because we don't use it ourselves

Actually the CMake is used for the Android build and I have tested that the Android app still builds and runs with the changes in all of the CMake PRs.